-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tpu): add tpu queued resources create/get/delete/forceDelete samples #9613
Open
TetyanaYahodska
wants to merge
16
commits into
main
Choose a base branch
from
tpu-queued-resources-crud-operations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests
product-auto-label
bot
added
api: tpu
Issues related to the Cloud TPU API.
samples
Issues that are directly related to samples.
labels
Oct 29, 2024
TetyanaYahodska
added
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Oct 29, 2024
This was referenced Oct 29, 2024
TetyanaYahodska
requested review from
yoshi-approver and
a team
as code owners
October 29, 2024 14:47
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
11 tasks
kokoro-team
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 1, 2024
TetyanaYahodska
added
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 1, 2024
11 tasks
kokoro-team
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 7, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue with Deleting operation in google.cloud.tpu_v2alpha1
When running on macOS, the user will encounter an IllegalStateException, which is better handled at the library level and not delegated to the user, as it does not affect the delete method, since it is successful.
2.We are using the v2alpha1 library to delete Queued Resources and we faced an issue with the unpack operation even though it still succeeds. I have handled this in a catch block, but I believe that this is not a very good way to pass this exception to the end user.
Log file - log.txt
Sample in Python - https://github.com/GoogleCloudPlatform/python-docs-samples/pull/12716/files
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only